SyntaxTraversal.Traverse → ParsedInput.tryPick (etc.)
#1241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntaxTraversal.Traverse/SyntaxVisitorBase<_>API to one of the analogous APIs added to FCS in Add higher-order-function-based API for working with untyped AST dotnet/fsharp#16462 — usuallyParsedInput.tryPick, occasionally alsoParsedInput.tryNodeorParsedInput.tryPickLast.ParsedInput.tryPick.Note: while
SyntaxCollectorBase+walkAstcould also theoretically be replaced byParsedInput.fold, I have not done so in this PR.Footnotes
The one usage I didn't update is
tryGetExplicitTypeInfo— this would in theory actually be quite easy to solve usingParsedInput.tryNode, except that I discovered that FCS doesn't actually calldive/pickfor patterns (like it does for expressions and other node types) and usesList.tryPickinstead, which means that the deepest matching pattern is not always returned. I may try to see if that's something that can be fixed in FCS. ↩