Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

Conversation

YaAvi
Copy link

@YaAvi YaAvi commented Jun 1, 2016

No description provided.

@gortok
Copy link
Contributor

gortok commented Jun 27, 2016

In the "Files changed", it only shows the plugin file; it doesn't show that you added it to the list of plugins. did you forget to do that or revert that action in one of your commits?

@YaAvi
Copy link
Author

YaAvi commented Jun 27, 2016

I reverted.
I thought I'm only supposed to commit the files under "./src/plugins"...
Should I add it to the list?

@gortok
Copy link
Contributor

gortok commented Jun 28, 2016

yes

@gortok gortok merged commit 807db3e into ionic-team:dev-next Jul 6, 2016
gortok added a commit that referenced this pull request Jul 6, 2016
* added method to src,mocks, and respective tests (#1218)

* update localNotification.ctrl.js (#1213)

i think, to be able to calculate "_60_seconds_from_now", the "now" value has to be a number, so I added the "getTime()" method

* $cordovaAppRate sets callbacks correctly (onButtonClicked, onRateDialogShow) (#1209)

* Wrapper for 3d touch plugin (#1155)

* Add wrapper for 3d plugin

* Fixed JSHint warnings for undefined variable

* added iosOptions to $cordovaSpinnerDialog.show() (#1224)

* added iosOptions to $cordovaSpinnerDialog.show()

* added missing comma

* added additional test for options in spinnerDialog.show() method

* Updated appVersion mocks and added tests (#1231)

* Issue #1228 - google analytics (#1247)

* Add key param check

* Tests fix

* Tests fix

* Added shareWithOptions, which was introduced in 5.1.0 (#1263)

See
https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin#using-the-share-sheet
for usage details

* added tts plugin wrapper (#1265)

* added tts plugin wrapper

* commit only tts.js

* only commit plugin

* Add serial plugin wrapper (#1274)

* Add cordovaSerial plugin wrapper and unit tests

* Update README with serial plugin

* Add serial to jshint globals

* added recents control plugin wrapper (#1264)

* added recents control plugin

* built added recents control plugin

* added plugin to plugin list

* added tts plugin wrapper

* commit only tts.js

* only commit plugin

* only commit recents plugin

* remove tts plugin

* added plugin to list

* added coma :|
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants