This repository was archived by the owner on Sep 15, 2021. It is now read-only.
Added $cordovaProgress Mock Fix #1126 #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
re-issue? We just fixed an issue with our Jasmine/Karma instance and I want to make sure it still builds. |
|
turns out if I close and re-open, I can trigger another build through Travis. TIL. |
|
@leocaseiro Can you strip the commit from this branch that changes the ng-cordova /dist files? If we include those changed files, it causes merge issues down the line. I'll also add something to the contributing.md so this is more apparent to others. |
leocaseiro
force-pushed
the
add-progressIndicator
branch
from
24449ad to
c16c5d4
Compare
|
Would you like to check it now, @gortok? Is that what I should've done? |
|
👍 😄 🍺 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mock for $cordovaProgress. It'll show console.info which can be used for Browser testing as well.