This repository was archived by the owner on Sep 15, 2021. It is now read-only.
Switch mode network mock #1136
Merged
Switch mode network mock #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@francesco-strazzullo thanks for the PR - however would you mind removing the |
|
Ok I'll remove the build files right away |
|
@pbernasconi I've removed the dist files but I can't figure out why the build is failed. I have all green tests on my machine. |
|
We had to upgrade our Jasmine instance. Thanks to #1174; it was fixed. Try again? |
|
turns out if I close and re-open, I can trigger another build through Travis. TIL. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous version of $cordovaNetwork mock you cannot test the switch to offline mode and viceversa. I've added two methods that will do that launching the right events through the rootscope.