Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

PR #1231 still not in alpha, also Content of /dist is outdated #1283

@matthieuxyz

Description

@matthieuxyz

I want to update my version of ng-cordova so that I can profit of this PR #1231 unfortunately this commit is still on the dev-next branch.

That isn't a problem in itself, since I can still add '"ngCordova": "dev-next"' to my bower.json. But if bower pull the git from this branch, the content of ./dist (ng-cordova-mocks.js) doesn't include the changes from this PR! Bower also don't include source file so I can't add a task in gulp to build it.

The code changes in this PR are trivial, but important in order to not breaks unit tests, and yet they are:

  • still not in any alpha release
  • not built in ./dist

I don't have any other choice than to git clone outside of my project, build it and copy the ng-cordova-mocks.js which is ridiculously complicated for an update this trivial.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions