Skip to content

Conversation

@averyjohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Playwright migration

What is the current behavior?

Tests are written in Puppeteer.

Issue URL: N/A

What is the new behavior?

Tests migrated to Playwright.

Redundant tests removed:

  • Anything RTL-specific
  • A11y screenshot test (covered by Basic test)
  • Mode-specific accordions in Basic test
  • Multiple-selection accordion in Basic test (covered by Multiple test)

Also added values to accordions in the Basic test so inset styling is actually captured.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jun 22, 2022
@averyjohnston averyjohnston marked this pull request as ready for review June 23, 2022 19:00
@averyjohnston averyjohnston requested a review from a team June 23, 2022 19:00
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some screenshots appear to be cut off at the bottom:

core/src/components/accordion/test/standalone/accordion.e2e.ts-snapshots/accordion-standalone-ios-ltr-Mobile-Safari-linux.png
core/src/components/accordion/test/standalone/accordion.e2e.ts-snapshots/accordion-standalone-ios-rtl-Mobile-Safari-linux.png
core/src/components/accordion/test/standalone/accordion.e2e.ts-snapshots/accordion-standalone-md-ltr-Mobile-Safari-linux.png
core/src/components/accordion/test/standalone/accordion.e2e.ts-snapshots/accordion-standalone-md-rtl-Mobile-Safari-linux.png

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants