Skip to content

fix(cordova): Update build output path #5079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(cordova): Update build output path #5079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f52f3c6
remove default build dir overrides
MaximBelov Feb 16, 2024
b0b7842
Merge branch 'develop' into update-build-output
MaximBelov Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/@ionic/cli/src/lib/integrations/cordova/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import { FatalException } from '../../errors';
const debug = Debug('ionic:lib:cordova:project');

const CORDOVA_ANDROID_PACKAGE_PATH = 'platforms/android/app/build/outputs/apk/';
const CORDOVA_IOS_SIMULATOR_PACKAGE_PATH = 'platforms/ios/build/emulator';
const CORDOVA_IOS_DEVICE_PACKAGE_PATH = 'platforms/ios/build/device';
const CORDOVA_IOS_PACKAGE_PATH = 'platforms/ios/build';

export async function getPlatforms(projectDir: string): Promise<string[]> {
const platformsDir = path.resolve(projectDir, 'platforms');
Expand Down Expand Up @@ -74,11 +73,12 @@ export async function getPackagePath(root: string, appName: string, platform: st
if (platform === 'android') {
return getAndroidPackageFilePath(root, { emulator, release });
} else if (platform === 'ios') {
const configuration = release ? 'Release' : 'Debug';
if (emulator) {
return path.join(CORDOVA_IOS_SIMULATOR_PACKAGE_PATH, `${appName}.app`);
return path.join(CORDOVA_IOS_PACKAGE_PATH, `${configuration}-iphonesimulator`, `${appName}.app`);
}

return path.join(CORDOVA_IOS_DEVICE_PACKAGE_PATH, `${appName}.ipa`);
return path.join(CORDOVA_IOS_PACKAGE_PATH, `${configuration}-iphoneos` , `${appName}.ipa`);
}

throw new FatalException(`Unknown package path for ${input(appName)} on ${input(platform)}.`);
Expand Down