Skip to content

[UI] Edit fix #9367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

[UI] Edit fix #9367

merged 2 commits into from
Mar 24, 2025

Conversation

SchrodingersGat
Copy link
Member

Prevent edit dialog for:

  • Top level part category
  • Top level stock location

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed backport Apply this label to a PR to enable auto-backport action User Interface Related to the frontend / User Interface backport-to-0.17.x Backport these changes to the 0.17.x branch labels Mar 24, 2025
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit b5f728d
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67e10c9b8bb9b00008329e37
😎 Deploy Preview https://deploy-preview-9367--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.95%. Comparing base (3ec8832) to head (b5f728d).
Report is 233 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/pages/part/CategoryDetail.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9367      +/-   ##
==========================================
- Coverage   85.97%   85.95%   -0.02%     
==========================================
  Files        1217     1217              
  Lines       53289    53294       +5     
  Branches     2285     2287       +2     
==========================================
- Hits        45813    45809       -4     
- Misses       6890     6895       +5     
- Partials      586      590       +4     
Flag Coverage Δ
web 69.72% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SchrodingersGat SchrodingersGat merged commit 8997f19 into inventree:master Mar 24, 2025
31 checks passed
@SchrodingersGat SchrodingersGat deleted the edit-fix branch March 24, 2025 08:24
github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
* Fix for editing stock location

* Fix for editing part category

(cherry picked from commit 8997f19)
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Mar 24, 2025
* Fix for editing stock location

* Fix for editing part category

(cherry picked from commit 8997f19)

Co-authored-by: Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant