Skip to content

feat: fix NLP in GET request #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

feat: fix NLP in GET request #9

merged 2 commits into from
Oct 3, 2023

Conversation

Nishant-sehgal
Copy link
Contributor

Unit Test needs to be fixed for all. Following the same format for now. It shows unnecessary stubbing.

Checklist

  • I've read and agree to the project's contribution guidelines.
  • I'm requesting to pull a topic/feature/bugfix branch.
  • I checked that my code additions will pass code linting checks and unit tests.
  • I updated unit and integration tests (if applicable).
  • I'm ready to notify the team of this contribution.

Description

What does this change do and why?

[Link to JIRA]

Thank you!

aditi2205
aditi2205 previously approved these changes Oct 3, 2023
View reviewed changes
@aditi2205 aditi2205 merged commit 44c9259 into intuit:master Oct 3, 2023
@Nishant-sehgal
Copy link
Contributor Author

This fixes: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditi2205 aditi2205 aditi2205 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nishant-sehgal @aditi2205