Skip to content

Conversation

@latonv
Copy link
Contributor

@latonv latonv commented Sep 27, 2025

Two changes in preparation for the new search beta:

  • Box shadows on tiles are currently always dark and thick. To allow more flexibility in how tiles are displayed in various contexts, this PR exposes two CSS vars that allow them to be customized more easily.
  • The smart facets regain a text label, which is now customizable from outside the component.
  • Clicking the default label of a smart facet dropdown now selects it immediately, rather than opening the dropdown menu (consistent with how the sort bar dropdowns function). Dropdown menus can still be opened by clicking the arrow.

@github-actions
Copy link

github-actions bot commented Sep 27, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-29 16:19 UTC

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 30.06993% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.64%. Comparing base (39349b1) to head (11be115).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../collection-facets/smart-facets/smart-facet-bar.ts 15.30% 83 Missing ⚠️
...ection-facets/smart-facets/smart-facet-dropdown.ts 53.84% 12 Missing ⚠️
src/collection-browser.ts 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   92.98%   92.64%   -0.34%     
==========================================
  Files         112      112              
  Lines       18537    18641     +104     
  Branches     1455     1456       +1     
==========================================
+ Hits        17236    17270      +34     
- Misses       1230     1300      +70     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@latonv latonv changed the title WEBDEV-7768 Allow tile box shadows to be customized via CSS var WEBDEV-7768 Search beta: Tile box shadow customization & smart facet adjustments Sep 27, 2025
@latonv latonv force-pushed the webdev7768-beta-search-iteration branch from 863ee54 to 0196fb6 Compare September 27, 2025 21:13
Copy link
Contributor

@bfalling bfalling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@latonv latonv merged commit afb2b0c into main Sep 29, 2025
2 of 4 checks passed
@latonv latonv deleted the webdev7768-beta-search-iteration branch September 29, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants