WEBDEV-7587 Do not purge ongoing facet requests when resetting pages #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 92.69% 92.71% +0.02%
==========================================
Files 109 109
Lines 17488 17490 +2
Branches 1368 1372 +4
==========================================
+ Hits 16210 16216 +6
+ Misses 1215 1211 -4
Partials 63 63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbuckner
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the management UI is opened, we attempt to load a larger first page of results, which entails resetting any pages that have been loaded in already. Currently this invalidates all fetches in progress by the data source, including facet fetches.
However, since the facets will be the same with either result set, we do still want those fetches to succeed. This PR ensures we do not invalidate facet fetches when resetting the result pages for item management.