Skip to content

Conversation

@latonv
Copy link
Contributor

@latonv latonv commented Jun 5, 2025

  • Adjusts styling and behavior for the smart facet bar to match the latest specs.
  • Emits events necessary for the parent page to respond to smart facet changes appropriately.

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-12 01:44 UTC

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 40 lines in your changes missing coverage. Please review.

Project coverage is 92.61%. Comparing base (ace707a) to head (2e61825).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../collection-facets/smart-facets/smart-facet-bar.ts 57.89% 16 Missing ⚠️
src/collection-browser.ts 65.71% 12 Missing ⚠️
...ection-facets/smart-facets/smart-facet-dropdown.ts 66.66% 7 Missing ⚠️
...t-facets/heuristics/wikidata/wikidata-heuristic.ts 0.00% 4 Missing ⚠️
...llection-facets/smart-facets/smart-facet-button.ts 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   92.72%   92.61%   -0.12%     
==========================================
  Files         107      108       +1     
  Lines       17217    17303      +86     
  Branches     1349     1353       +4     
==========================================
+ Hits        15965    16025      +60     
- Misses       1192     1218      +26     
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@latonv latonv merged commit 56edbc9 into main Jun 12, 2025
2 of 4 checks passed
@latonv latonv deleted the smart-bubble-style-updates branch June 12, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants