chore: update OpenCV version in openvino-tensor-converter
#88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `openvino-tensor-converter` crate is a helpful extension to this project but not crucial, thus it does not receive as much attention as other parts. It is useful for generating tensor files of various shapes from images (e.g., for test fixtures), so I haven't felt the need to remove it yet. Its dependencies had fallen far out of date and included a very old version of `shlex` that has security vulnerabilities. By updating to the latest `opencv` crate version, this dependency is also updated. This change also updates the converter code to fit the latest `opencv` API shape and `cargo-clippy` guidance.
abrown
added a commit
to abrown/openvino-rs
that referenced
this pull request
Jun 10, 2025
As pointed out by code scan [intel#88], `std::sync::LazyLock` is the standard way to initialize static values. `LazyLock` has been available since Rust [v1.80.0]. This change switches to `LazyLock` and removes the now-unnecessary `once_cell` crate. It also throws a few `rust-version` annotations in to remind users what version of Rust to use. [intel#88]: https://github.com/intel/openvino-rs/security/code-scanning/88 [v1.80.0]: https://releases.rs/docs/1.80.0
abrown
added a commit
to abrown/openvino-rs
that referenced
this pull request
Jun 10, 2025
As pointed out by code scan [intel#88], `std::sync::LazyLock` is the standard way to initialize static values. `LazyLock` has been available since Rust [v1.80.0]. This change switches to `LazyLock` and removes the now-unnecessary `once_cell` crate. It also throws a few `rust-version` annotations in to remind users what version of Rust to use. [intel#88]: https://github.com/intel/openvino-rs/security/code-scanning/88 [v1.80.0]: https://releases.rs/docs/1.80.0
rahulchaphalkar
pushed a commit
that referenced
this pull request
Jun 10, 2025
As pointed out by code scan [#88], `std::sync::LazyLock` is the standard way to initialize static values. `LazyLock` has been available since Rust [v1.80.0]. This change switches to `LazyLock` and removes the now-unnecessary `once_cell` crate. It also throws a few `rust-version` annotations in to remind users what version of Rust to use. [#88]: https://github.com/intel/openvino-rs/security/code-scanning/88 [v1.80.0]: https://releases.rs/docs/1.80.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openvino-tensor-convertercrate is a helpful extension to this project but not crucial, thus it does not receive as much attention as other parts. It is useful for generating tensor files of various shapes from images (e.g., for test fixtures), so I haven't felt the need to remove it yet. Its dependencies had fallen far out of date and included a very old version ofshlexthat has security vulnerabilities. By updating to the latestopencvcrate version, this dependency is also updated. This change also updates the converter code to fit the latestopencvAPI shape andcargo-clippyguidance.