fix: clippy warnings #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevelr <[email protected]>
abrown
reviewed
Oct 6, 2023
| pub use tensor_desc::TensorDesc; | ||
|
|
||
| /// # Panics | ||
| /// |
There was a problem hiding this comment.
Same "explain the panic" comment as below.
| .all(|w| w[0].version == w[1].version) | ||
| { | ||
| anyhow!( | ||
| return Err(anyhow!( |
There was a problem hiding this comment.
Can we just use bail! here? I haven't been too worried about xtask since it is essentially repo-internal scripts, but thanks for fixing this!
| .all(|w| w[0].version == w[1].version) | ||
| { | ||
| anyhow!( | ||
| return Err(anyhow!( |
There was a problem hiding this comment.
Same bail! comment as above.
| } | ||
|
|
||
| /// # Panics | ||
| /// |
There was a problem hiding this comment.
I think clippy is looking for something like:
/// Find the path...
///
/// # Panics
/// This function panics if it fails to find and load an OpenVINO library.
They want us to describe the conditions under which this panics.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: clippy warnings and missing error return
A couple of these looked like actual bugs, where an
anyhow!error was generated but not returned