Skip to content

Double-check size of returned blob dimensions #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Double-check size of returned blob dimensions #58

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
512e140
Double-check size of returned blob dimensions
abrown Jan 4, 2023
a256f28
fix: avoid `as_bytes`
abrown Jan 4, 2023
2abeb25
fix: use `.dims.len()`
abrown Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/openvino/src/blob.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ impl Blob {

let mut dimensions = MaybeUninit::uninit();
try_unsafe!(ie_blob_get_dims(blob, dimensions.as_mut_ptr()))?;
// Safety: this assertion is trying to avoid the improbable case where some future version
// of the OpenVINO library returns a dimensions array with size different than the one
// auto-generated in the bindings; see `struct dimensions` in
// `openvino-sys/src/generated/types.rs`. It is not clear to me whether this will return the
// statically-expected size or the dynamic size -- this is not effective in the former case.
assert_eq!(unsafe { dimensions.assume_init() }.dims.len(), 8);

let mut precision = MaybeUninit::uninit();
try_unsafe!(ie_blob_get_precision(blob, precision.as_mut_ptr()))?;
Expand Down