Add Blob::buffer_as_type() #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
approved these changes
Nov 29, 2022
| /// | ||
| /// Panics if the returned OpenVINO size will not fit in `usize`. | ||
| pub fn byte_len(&mut self) -> Result<usize> { | ||
| pub fn byte_len(&self) -> Result<usize> { |
There was a problem hiding this comment.
I believe these &mut self to &self changes make sense in a Rust context but I propagated the mut due to ie_blob_byte_size's signature (e.g.), which takes a *mut ie_blob_t. I wasn't sure if this was just some bindgen over-reaction or if indeed there was some possible underlying mutation. Looking at ie_blob.h now, I see that both size and byteSize are declared const member functions so this should be safe.
|
|
||
| /// Retrieve the [`Blob`]'s data as an immutable slice of bytes. | ||
| pub fn buffer(&mut self) -> Result<&[u8]> { | ||
| pub fn buffer(&self) -> Result<&[u8]> { |
There was a problem hiding this comment.
The original &mut self here was probably a typo.
| // read too many bytes, so we manually calculate the resulting slice `size`. | ||
| let size = self.byte_len()? / std::mem::size_of::<T>(); | ||
| let slice = std::slice::from_raw_parts(buffer.__bindgen_anon_1.buffer.cast::<T>(), size); | ||
| Ok(slice) |
There was a problem hiding this comment.
It would be ideal to de-duplicate this but the from_raw_parts is different so don't worry about it.
chemicstry
force-pushed
the
buffer_as_type
branch
from
c45b988 to
3159255
Compare
chemicstry
force-pushed
the
buffer_as_type
branch
from
3159255 to
4d97fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an immutable version of
buffer_mut_as_type()like there isbuffer()andbuffer_mut().Also fixes mutability of methods that shouldn't require
&mut self. If there was a reason why these methods needed to bemut, let me know.