Feature/send and sync #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the classes seem Send as there isn't any thread local magic going on. CNNNetwork seems Sync unless binding to a session somehow mutates the network. |
|
The CI failure you observed is not due to your changes; I opened and merged #49 to avoid that and if you rebase on |
geekbeast
force-pushed
the
feature/send-and-sync
branch
from
773fb26 to
fb95288
Compare
abrown
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
After some discussion with the OpenVINO team, I think this change is fine to merge:
- the structures marked
Sendare safe to send to other threads because these structures have exclusive ownership of OpenVINO's raw pointer, which can be sent to any thread. This is usage similar to the the Send and Sync example. - the structures can indeed be marked
Sync, indicating that they can be shared between threads, since Rust will enforce exclusive mutable access and the underlying C++ methods which use&selfare thread-safe (e.g., as tested here, here, and here). More could probably be markedSyncbut this should be fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary compiler promises to allow use of openvino backend in Viceroy and other wasmtime derived platforms.