Skip to content

Conversation

@rahulchaphalkar
Copy link
Contributor

  • Resolves Unable to retrieve core properties #122
  • Removed functions which allowed get/set properties without device name. This use case is not documented in openvino docs, and the openvino c-api do not allow not passing device name, so this change adheres to that.
  • Pass property_key as reference instead of value
  • Added tests related to supported properties and RW properties for CPU
  • I've opened an issue here [Good First Issue]: Set/Get Properties in C-API openvinotoolkit/openvino#24911 and will update with more tests based on the resolution there at a later point if need be (for example adding more tests checking unsupported cpu properties etc. It is undocumented right now, so haven't added those tests yet).

@rahulchaphalkar rahulchaphalkar requested a review from abrown June 10, 2024 21:12
@abrown abrown merged commit 0045461 into intel:main Jun 12, 2024
@abrown abrown deleted the add-core-property branch June 12, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to retrieve core properties

2 participants