Skip to content

Conversation

@rahulchaphalkar
Copy link
Contributor

  • Add property enum
  • Add version module

@rahulchaphalkar rahulchaphalkar requested a review from abrown May 17, 2024 22:28
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It occurs to me that we should link to the documentation for these properties in case someone is interested in knowing what they actually do.

PropertyKey::RangeForAsyncInferRequests => "RANGE_FOR_ASYNC_INFER_REQUESTS",
PropertyKey::RangeForStreams => "RANGE_FOR_STREAMS",
PropertyKey::DeviceFullName => "FULL_DEVICE_NAME",
PropertyKey::DeviceCapabilities => "OPTIMIZATION_CAPABILITIES",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PropertyKey::DeviceCapabilities => "OPTIMIZATION_CAPABILITIES",
PropertyKey::DeviceCapabilities => "DEVICE_CAPABILITIES",

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with property keys where these naming discrepancies between device<->optimization , model<->network exist

RwPropertyKey::HintPerformanceMode => "PERFORMANCE_HINT",
RwPropertyKey::HintSchedulingCoreType => "SCHEDULING_CORE_TYPE",
RwPropertyKey::HintInferencePrecision => "INFERENCE_PRECISION_HINT",
RwPropertyKey::HintNumRequests => "PERFORMANCE_HINT_NUM_REQUESTS",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here?

@abrown abrown merged commit 2f5bdd3 into intel:main May 18, 2024
@abrown abrown deleted the add-enums branch May 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants