Fix several clippy-related issues #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `cargo clippy` revealed several small issues that this change fixes.
| Ok(PreProcessOutputInfo { | ||
| instance: output_info, | ||
| }) | ||
| Ok(PreProcessOutputInfo { instance }) |
There was a problem hiding this comment.
Replacing output_info by instance and similar changes seem good for conciseness, would you want to keep it uniform and make similar changes throughout? E.g. get_output_info_get_tensor_info and several others.
There was a problem hiding this comment.
Just wait for the next PR... I am about to rename all of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running
cargo clippyand resolving some of the warnings; it also refactors a few functions and improves some documentation, but does not change any logic.