Skip to content

[SYCL][NFC] Fix min/max conflict on Windows #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2022
Merged

[SYCL][NFC] Fix min/max conflict on Windows #7768

merged 1 commit into from
Dec 13, 2022

Conversation

againull
Copy link
Contributor

@againull againull commented Dec 13, 2022 •
edited
Loading

Fix conflict with min/max macro on Windows in a similar way as in the #1339
This is needed to fix post-commit failure - https://github.com/intel/llvm/actions/runs/3687931956/jobs/6242122359

@againull againull requested a review from a team as a code owner December 13, 2022 21:10
@againull againull requested a review from romanovvlad December 13, 2022 21:10
@againull againull mentioned this pull request Dec 13, 2022
Merged
@againull againull merged commit 0299ac1 into intel:sycl Dec 13, 2022
@againull againull deleted the minmax_macro_issue branch December 14, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@romanovvlad romanovvlad Awaiting requested review from romanovvlad romanovvlad is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@againull @aelovikov-intel