Skip to content

[SYCL] Avoid overuse of CPU on wait read-write lock loop #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2020
Merged

[SYCL] Avoid overuse of CPU on wait read-write lock loop #2525

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0fc609
[SYCL] Avoid overuse of CPU on wait mutex loop
vladimirlaz Sep 23, 2020
fa932e7
[SYCL] revert unnecessary change
vladimirlaz Sep 23, 2020
e13fd3c
[SYCL] add comment describing change
vladimirlaz Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sycl/source/detail/scheduler/scheduler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@
#include <detail/scheduler/scheduler.hpp>
#include <detail/stream_impl.hpp>

#include <chrono>
#include <memory>
#include <mutex>
#include <set>
#include <thread>
#include <vector>

__SYCL_INLINE_NAMESPACE(cl) {
Expand Down Expand Up @@ -268,7 +270,11 @@ void Scheduler::lockSharedTimedMutex(
// TODO: after switching to C++17, change std::shared_timed_mutex to
// std::shared_mutex and use std::lock_guard here both for Windows and Linux.
while (!Lock.owns_lock()) {
Lock.try_lock();
Lock.try_lock_for(std::chrono::milliseconds(10));
// Without yield while loop acts like endless while loop and occupies the
// whole CPU when multiple command groups are created in multiple host
// threads
std::this_thread::yield();
}
#else
// It is a deadlock on UNIX in implementation of lock and lock_shared, if
Expand Down