Skip to content

[SYCL][NFC] Remove workaround for SPIR-V translator issues #2450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2020
Merged

[SYCL][NFC] Remove workaround for SPIR-V translator issues #2450

merged 3 commits into from
Sep 10, 2020

Conversation

bader
Copy link
Contributor

@bader bader commented Sep 9, 2020

No description provided.

@bader bader mentioned this pull request Sep 9, 2020
Closed
@bader bader marked this pull request as ready for review September 9, 2020 14:01
@bader bader requested a review from a team as a code owner September 9, 2020 14:01
@bader bader requested a review from rbegam September 9, 2020 14:01
@bader
Copy link
Contributor Author

bader commented Sep 10, 2020

@intel/llvm-reviewers-runtime, @rbegam, ping.

s-kanaev
s-kanaev approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Though, I have only a single question to placate my curiosity.

@bader bader merged commit f6418b4 into intel:sycl Sep 10, 2020
@bader bader deleted the optimizations branch September 10, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbegam rbegam Awaiting requested review from rbegam

2 more reviewers

@alexbatashev alexbatashev alexbatashev approved these changes

@s-kanaev s-kanaev s-kanaev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bader @alexbatashev @s-kanaev