[CI] Remove dependency on bot user for uploading benchmark CI results #20333
Conversation
|
|
||
| permissions: | ||
| contents: read | ||
| contents: write |
There was a problem hiding this comment.
can we set the write permission only at the job step(s) that ened it?
There was a problem hiding this comment.
Let me attempt this and I'll get back to you
There was a problem hiding this comment.
Looks like permissions have a job-level granularity, I can't just give it to a single step.
Doesn't make much sense to nest an additional write permission for the job given that there is only a single job in the entire workflow, are we cool to keep it like this?
| env: | ||
| RUNNER_TAG: ${{ inputs.runner }} | ||
| GITHUB_TOKEN: ${{ secrets.LLVM_SYCL_BENCHMARK_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
can we try removing this line? i think GITHUB_TOKEN is automatically passed
| results_file="$(git diff HEAD~1 --name-only -- results/ | head -n 1)" | ||
| if git push "https://[email protected]/intel/llvm-ci-perf-results.git" "$results_branch"; then | ||
| if git push; then |
There was a problem hiding this comment.
dont we need to specify the branch?
There was a problem hiding this comment.
Looks to be already configured by actions/checkout@v5; I figured it was better to specify the branch once than to specify the branch multiple times.
3 participants
This PR:
benchmark-ci-testsbranch instead of intel/llvm-ci-perf-resultsTest run: https://github.com/intel/llvm/actions/runs/18386952310/job/52388325821 (job failed due to "regression"; issue should be addressed with the merge of #20277