-
Notifications
You must be signed in to change notification settings - Fork 792
[SYCL] Remove deprecated sycl device library driver options #20326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not. |
We just had an email conversation about a different API breaking change, and we decided that we should wait until the oneAPI "breaking change window". I assume this falls into the same category. |
I think I may have asked this before, but I forgot. How do we plan to handle the inclusion of "libsycl-native-bfloat16.spv" vs. "libsycl-fallback-bfloat16.spv" if we remove the onlink link capability? |
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Hi, @gmlueck |
Yes, the original plan is to mark these devicelib related options as 'depreacted' before oneAPI 2025.2 and remove them in oneAPI 2026.0. |
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Driver changes LGTM.
My understanding from @vkurkov is that we need to wait for the "breaking change window" before removing any deprecated features that are targeted for removal in 2026.0. He says that window opens on November 18, but he is working on a plan to open it on November 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preventing merge before ABI breaking window opens.
SYCL device library related driver options were marked as 'deprecated' and plans to be removed in future major release, this PR removes these driver options and clears all components dealing with these options, all related tests are updated as well.
Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.