Skip to content

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Oct 9, 2025

SYCL device library related driver options were marked as 'deprecated' and plans to be removed in future major release, this PR removes these driver options and clears all components dealing with these options, all related tests are updated as well.
Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.

Signed-off-by: jinge90 <[email protected]>
@aelovikov-intel
Copy link
Contributor

I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not.

@gmlueck
Copy link
Contributor

gmlueck commented Oct 9, 2025

I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not.

We just had an email conversation about a different API breaking change, and we decided that we should wait until the oneAPI "breaking change window". I assume this falls into the same category.

@gmlueck
Copy link
Contributor

gmlueck commented Oct 9, 2025

Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.

I think I may have asked this before, but I forgot. How do we plan to handle the inclusion of "libsycl-native-bfloat16.spv" vs. "libsycl-fallback-bfloat16.spv" if we remove the onlink link capability?

@jinge90
Copy link
Contributor Author

jinge90 commented Oct 11, 2025

Removing these device library related driver options is prerequisite to clear sycl device library 'online' link path in current sycl runtime and compiler which we have decided to remove to get rid of unnecessary complexity.

I think I may have asked this before, but I forgot. How do we plan to handle the inclusion of "libsycl-native-bfloat16.spv" vs. "libsycl-fallback-bfloat16.spv" if we remove the onlink link capability?

Hi, @gmlueck
We have discussion about this several months ago, the conclusion was relying on sycl dynamic libraries mechanism and embed required bf16 spvs into final executable. This was finished before oneAPI 2025.2 release and current bfloat16 functionality doesn't depend on devicelib 'online link' path.
I will send the original mail thread to you offline.
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Oct 11, 2025

I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not.

We just had an email conversation about a different API breaking change, and we decided that we should wait until the oneAPI "breaking change window". I assume this falls into the same category.

Yes, the original plan is to mark these devicelib related options as 'depreacted' before oneAPI 2025.2 and remove them in oneAPI 2026.0.
Thanks very much.

Signed-off-by: jinge90 <[email protected]>
Copy link
Contributor

@srividya-sundaram srividya-sundaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Driver changes LGTM.

@gmlueck
Copy link
Contributor

gmlueck commented Oct 13, 2025

I believe @vkurkov @stdale-intel @gmlueck and @xtian-github should decide if we can make this change now or not.

We just had an email conversation about a different API breaking change, and we decided that we should wait until the oneAPI "breaking change window". I assume this falls into the same category.

Yes, the original plan is to mark these devicelib related options as 'depreacted' before oneAPI 2025.2 and remove them in oneAPI 2026.0. Thanks very much.

My understanding from @vkurkov is that we need to wait for the "breaking change window" before removing any deprecated features that are targeted for removal in 2026.0. He says that window opens on November 18, but he is working on a plan to open it on November 1.

Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preventing merge before ABI breaking window opens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants