Skip to content

Conversation

YuriPlyakhin
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin commented Oct 3, 2025

Intention is to post it to discourse as RFC. Not to be merged to sycl branch. Created for discussion and feedback. Hence, I'll keep it in draft mode, while I'll request reviews.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.
A few minor nits.

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to post.

@bader bader requested a review from sarnex October 13, 2025 23:18
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few more nits.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small comment, but otherwise this looks great!

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm at a high level, technical details are better for the actual rfc, just a minor requirement question

@YuriPlyakhin
Copy link
Contributor Author

YuriPlyakhin commented Oct 15, 2025

Posted: https://discourse.llvm.org/t/rfc-syclbin-a-format-for-sycl-device-code/88603
Closing.

UPD:

Hello,
Our automated spam filter, Akismet, has temporarily hidden your post in [RFC] SYCLBIN - A Format for SYCL Device Code for review.
A staff member will review your post soon, and it should appear shortly.
We apologize for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants