[SYCL] Add std::hash and std::numeric_limits specialization for bfloat16 #19838
Conversation
This commit adds the missing std::hash and std::numeric_limits specializations for the sycl::ext::oneapi::bfloat16 class. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@gmlueck - These are also specialized for |
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
I think we should update the bfloat16 extension spec to say that the extension does provide these specializations. Using For example, we could add a new section to the spec titled something like "Standard C++ library specializations" |
| // Friend traits. | ||
| friend std::numeric_limits<bfloat16>; | ||
| friend std::hash<bfloat16>; |
There was a problem hiding this comment.
Do we have any guarantees on the layout/size? If so, can we use bit_cast instead of friendship?
| // Specialization of some functions in namespace `std`. | ||
| namespace std { |
There was a problem hiding this comment.
Subjective, but I prefer
// in global ns
template <> struct std::{type}<types...> { ... };
| // RUN: %{build} -o %t.out | ||
| // RUN: %{run} %t.out |
There was a problem hiding this comment.
Looks like this belongs to sycl/test, not sycl/test-e2e
There was a problem hiding this comment.
Or even sycl/unittests
This commit adds the missing std::hash and std::numeric_limits specializations for the sycl::ext::oneapi::bfloat16 class.