[SYCL] Allow work group scratch memory to be used with free function kernels #19837
+95
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mark them with the appropriate attribute
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
requested a deployment
to
WindowsCILock
GitHub Actions
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a kernel uses implicit local memory such as by way of the
get_work_group_scratch_memoryfunction, the library is supposed to mark the kernel with the appropriate attributeWORK_GROUP_STATIC_ATTRto get things to work at runtime. This is done through the properties passed to the kernel invocation call. For free function kernels however, the infrastructure is not there to do this marking process and usage of the above mentioned function typically results in a UR error.This PR makes some changes at the middle-end level to traverse the call graph wherever the compiler built-in function
__sycl_allocateLocalMemoryis used and mark each of the kernels found during this traversal , including free function kernels, with theWORK_GROUP_STATIC_ATTRattribute if not already present.