Skip to content

[UR][L0] Remove Driver Exp Implementation of External Semaphore #19835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Aug 19, 2025

  • Intel L0 GPU Driver no longer supports the Driver Exp Implementation of External Semaphore and the code has been removed from the codebase, therefore the support needs to be removed from the adapter to allow compiling with newer ze_intel_gpu.h headers.
  • L0 Spec implementation is the only version required for customer support.

@nrspruit nrspruit requested review from a team as code owners August 19, 2025 18:43
@nrspruit
Copy link
Contributor Author

@intel/bindless-images-reviewers please review

@przemektmalon
Copy link
Contributor

@intel/bindless-images-reviewers please review

A short PR description would be useful here. Why were two implementations required before? And why is only one required now?

@nrspruit
Copy link
Contributor Author

@intel/bindless-images-reviewers please review

A short PR description would be useful here. Why were two implementations required before? And why is only one required now?

@intel/bindless-images-reviewers please review

A short PR description would be useful here. Why were two implementations required before? And why is only one required now?

Hello @przemektmalon , the driver experimental version was the initial implementation until the L0 spec had the support officially. Now that the L0 gpu driver supports the L0 spec version, the Driver Experimental version was deleted from the code base in the gpu driver and the definitions of the driver experimental external semaphore functions and structures no longer exist. We have to remove the usage of the old driver exp code otherwise the code will not compile if one updates the ze_intel_gpu.h headers used.

@nrspruit
Copy link
Contributor Author

@intel/llvm-gatekeepers , please merge

@igchor igchor merged commit 62b45cc into intel:sycl Aug 21, 2025
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants