Skip to content

[SYCL] Add copy/move ctors and assignment operators to sycl::detail::optional #19775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Alexandr-Konovalov
Copy link
Contributor

Currently, those are implicitly defined and perform bitwise copy of Storage, that is incorrect if T has non-trivial copy ctors etc.

…optional

Currently, those are implicitly defined and perform bitwise copy
of Storage, that is incorrect if T has non-trivial copy ctors etc.
@aelovikov-intel
Copy link
Contributor

Should this PR remove

# https://github.com/intel/llvm/pull/18314
Assert/assert_in_kernels.cpp
Assert/assert_in_multiple_tus.cpp
Assert/assert_in_multiple_tus_one_ndebug.cpp
Assert/assert_in_one_kernel.cpp
Assert/assert_in_simultaneous_kernels.cpp
Assert/assert_in_simultaneously_multiple_tus.cpp
Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp
as well?

@Alexandr-Konovalov Alexandr-Konovalov requested a review from a team as a code owner August 14, 2025 12:15
@Alexandr-Konovalov
Copy link
Contributor Author

Should this PR remove

# https://github.com/intel/llvm/pull/18314
Assert/assert_in_kernels.cpp
Assert/assert_in_multiple_tus.cpp
Assert/assert_in_multiple_tus_one_ndebug.cpp
Assert/assert_in_one_kernel.cpp
Assert/assert_in_simultaneous_kernels.cpp
Assert/assert_in_simultaneously_multiple_tus.cpp
Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp

as well?

Sure, missed.

@aelovikov-intel
Copy link
Contributor

@Alexandr-Konovalov , @AlexeySachkov , @KornevNikita , this needs cherry-picking both up/down-stream.

@aelovikov-intel aelovikov-intel merged commit ffc2512 into intel:sycl Aug 14, 2025
28 checks passed
@Alexandr-Konovalov
Copy link
Contributor Author

@Alexandr-Konovalov , @AlexeySachkov , @KornevNikita , this needs cherry-picking both up/down-stream.

@aelovikov-intel Could you please advise, how can I help with that?

@KornevNikita
Copy link
Contributor

@Alexandr-Konovalov don't worry, I'll do it. Just a cherry-pick to another branch.

@aelovikov-intel could you please add some small clarification comments to these devops/compat_ci_exclude.sycl-rel-* files regarding their purpose?

Do we need to cherry-pick this to both 6.2 and 6.3? Asking because we just published the 6.2.0 release, I guess this branch doesn't assume to get new commits if we don't plan to publish 6.2.1, but I may be wrong. @AlexeySachkov?

KornevNikita pushed a commit to KornevNikita/llvm that referenced this pull request Aug 19, 2025
…optional (intel#19775)

Currently, those are implicitly defined and perform bitwise copy of
Storage, that is incorrect if T has non-trivial copy ctors etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants