-
Notifications
You must be signed in to change notification settings - Fork 798
[SYCL] Add copy/move ctors and assignment operators to sycl::detail::optional #19775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add copy/move ctors and assignment operators to sycl::detail::optional #19775
Conversation
…optional Currently, those are implicitly defined and perform bitwise copy of Storage, that is incorrect if T has non-trivial copy ctors etc.
Should this PR remove llvm/devops/compat_ci_exclude.sycl-rel-6_2 Lines 52 to 59 in 39e2534
|
Sure, missed. |
@Alexandr-Konovalov , @AlexeySachkov , @KornevNikita , this needs cherry-picking both up/down-stream. |
@aelovikov-intel Could you please advise, how can I help with that? |
@Alexandr-Konovalov don't worry, I'll do it. Just a cherry-pick to another branch. @aelovikov-intel could you please add some small clarification comments to these Do we need to cherry-pick this to both 6.2 and 6.3? Asking because we just published the 6.2.0 release, I guess this branch doesn't assume to get new commits if we don't plan to publish 6.2.1, but I may be wrong. @AlexeySachkov? |
…optional (intel#19775) Currently, those are implicitly defined and perform bitwise copy of Storage, that is incorrect if T has non-trivial copy ctors etc.
Currently, those are implicitly defined and perform bitwise copy of Storage, that is incorrect if T has non-trivial copy ctors etc.