Skip to content

[SYCL] Make context constructors explicit to avoid unintended conversions #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2020
Merged

[SYCL] Make context constructors explicit to avoid unintended conversions #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sycl/include/CL/sycl/context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ class context {
/// @param AsyncHandler is an instance of async_handler.
/// @param UseCUDAPrimaryContext is a bool determining whether to use the
/// primary context in the CUDA backend.
context(const device &Device, async_handler AsyncHandler = {},
bool UseCUDAPrimaryContext = false);
explicit context(const device &Device, async_handler AsyncHandler = {},
bool UseCUDAPrimaryContext = false);

/// Constructs a SYCL context instance using the provided platform.
///
Expand All @@ -63,8 +63,8 @@ class context {
/// @param AsyncHandler is an instance of async_handler.
/// @param UseCUDAPrimaryContext is a bool determining whether to use the
/// primary context in the CUDA backend.
context(const platform &Platform, async_handler AsyncHandler = {},
bool UseCUDAPrimaryContext = false);
explicit context(const platform &Platform, async_handler AsyncHandler = {},
bool UseCUDAPrimaryContext = false);

/// Constructs a SYCL context instance using list of devices.
///
Expand All @@ -78,8 +78,9 @@ class context {
/// @param AsyncHandler is an instance of async_handler.
/// @param UseCUDAPrimaryContext is a bool determining whether to use the
/// primary context in the CUDA backend.
context(const vector_class<device> &DeviceList,
async_handler AsyncHandler = {}, bool UseCUDAPrimaryContext = false);
explicit context(const vector_class<device> &DeviceList,
async_handler AsyncHandler = {},
bool UseCUDAPrimaryContext = false);

/// Constructs a SYCL context instance from OpenCL cl_context.
///
Expand Down