[LoadStoreOpToLLVM] Improve rewriteTensorPointerStore
#4667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the rewriteTensorPointerStore function in the LoadStoreOpToLLVM conversion by removing a restrictive early check and refactoring the code for better clarity and maintainability. The changes enhance support for 2D block store operations with proper size constraints.
- Removes early failure condition that only allowed DPAS layout encoding
- Adds proper validation for 2D block store constraints (8 rows max, 64 bytes per row max)
- Refactors variable names and reorganizes code structure for better readability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| LoadStoreOpToLLVM.cpp | Removes DPAS-only restriction, adds 2D block store constraints, and refactors variable naming |
| blockptr_store.mlir | Updates test expectations to match the reordered variable declarations |
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
force-pushed
the
whitneywhtsang/store.0
branch
from
6cba681 to
848cdaa
Compare
whitneywhtsang
commented
Jul 10, 2025
whitneywhtsang
commented
Jul 10, 2025
chengjunlu
approved these changes
Jul 10, 2025
etiotto
approved these changes
Jul 10, 2025
third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Whitney Tsang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
rewriteTensorPointerStore: