Skip to content
This repository was archived by the owner on Jan 28, 2023. It is now read-only.

Conversation

wcwang
Copy link
Contributor

@wcwang wcwang commented Mar 25, 2020

Signed-off-by: Wenchao Wang [email protected]

@HaxmCI HaxmCI added CI:Build Pass CI:Build Pass CI:Mac Test Pass CI:Mac Test Pass labels Mar 25, 2020
@krytarowski
Copy link
Contributor

Please hold on, I want to add missing NetBSD support for new CPUID feature.

@krytarowski
Copy link
Contributor

Blocker: #281

@wcwang
Copy link
Contributor Author

wcwang commented Mar 26, 2020

@krytarowski, thanks for your contribution for NetBSD. Your patches made NetBSD always updated for HAXM. However, according to our release progress, we had launched the release process and QA team had started to test yesterday. Sorry for not including your immediate update in this release. We will leave more time for community activity next time. Never mind, we are going to plan the next release soon and will add NetBSD support definitely. This version is just a landing for HAX_VCPU_IOCTL_SET_CPUID, quite a few things, such as in-depth CPUID features setting, common header for POSIX, need to be accomplished. Your future contribution will be welcome.

@krytarowski
Copy link
Contributor

If this version is just for landing one feature, it shall not regress in generic functionality. Right now one of the supported targets is not buildable.

@krytarowski
Copy link
Contributor

But landing this in 7.6.1 is fine too.

@wcwang
Copy link
Contributor Author

wcwang commented Mar 26, 2020

Thanks for your reply. You are right. The build checks in Travis CI only cover 3 hosts. We have limited resource to cover NetBSD test. According to the previous commitment, we have to deliver HAXM release with this interface to our customers. Next time we will try to reserve more time for community to avoid such issue happened. Thanks for your understanding.

@wcwang
Copy link
Contributor Author

wcwang commented Mar 27, 2020

We will merge #281 and another patch and restart the release process. So cancel this release request first.

@wcwang wcwang closed this Mar 27, 2020
@wcwang wcwang deleted the release-7.6.0 branch March 27, 2020 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI:Build Pass CI:Build Pass CI:Mac Test Pass CI:Mac Test Pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants