Skip to content

Add min/max/mean/stddev to histogram #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add min/max/mean/stddev to histogram #34

wants to merge 1 commit into from

Conversation

@serban21
Copy link

Fixes #33

@zegelin
Copy link

zegelin commented Nov 22, 2019

This looks pretty good. Thanks.

For adherence to the Prometheus text format exposition format I'd prefer to keep the quantile labels on Summaries as floats, and instead export the min, max, etc. values as separate metrics -- for example metric_max, metric_min, etc.

@johndelcastillo johndelcastillo force-pushed the master branch 2 times, most recently from 3b88272 to 84cb7cd Compare October 19, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing histogram metrics

2 participants

@serban21 @zegelin