Skip to content

Rolling back #515. #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2019
Merged

Rolling back #515. #539

merged 1 commit into from
Nov 26, 2019

Conversation

@zenspider
Copy link
Contributor

@zenspider zenspider commented Nov 26, 2019 •
edited
Loading

#515 causes regressions shown in #538 which I think is a bigger affected
set of users.

Until we can get this under test and reproducible, it needs to wait.

Signed-off-by: Ryan Davis [email protected]

@zenspider
Rolling back #515.
8f168ee 
Causes regressions shown in #538 which I think is a bigger affected
set of users.

Until we can get this under test and reproducible, it needs to wait.

Signed-off-by: Ryan Davis <[email protected]>
@zenspider zenspider requested a review from a team as a code owner November 26, 2019 23:40
@ghost ghost requested review from clintoncwolfe and miah November 26, 2019 23:40
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Nov 26, 2019

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@zenspider
Copy link
Contributor Author

zenspider commented Nov 26, 2019

cc/ @christian-wtd

@zenspider zenspider self-assigned this Nov 26, 2019
@zenspider zenspider merged commit dfa48b2 into master Nov 26, 2019
@chef-expeditor chef-expeditor bot deleted the zenspider/rollback/515 branch November 26, 2019 23:52
@zenspider
Copy link
Contributor Author

zenspider commented Dec 4, 2019

This has been addressed via #544.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintoncwolfe clintoncwolfe Awaiting requested review from clintoncwolfe

1 more reviewer

@miah miah miah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zenspider zenspider

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zenspider @miah