Better stateful API #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to pass it in messages, like we used to in `MsgResp` in `typed-protocols-examples`. The `Driver` and `Codec` were modified: * `encode` and `sendMessage` receive the initial state of the protocol state transition imposed by a message, which is dual to * `decode` and `recvMessage` receive the final state of the protocol state transition imposed by a message This is seems more natural than always passing the final state. The drawback of this systemic approach is that every `Yield` needs access to both initial and final state of a transition. In previous approach one had more control over which messages require access to the initial state (e.g. `MsgRecv` in `Stateful.ReqResp`) - although it was looking more like a hack since that part of a message wasn't sent over the wire.
Also done for typed-protocols-stateful-codec.
Also use `cabal-version: 3.4` in all packages.
bolt12
approved these changes
Sep 26, 2024
This was referenced Sep 18, 2024
github-merge-queue bot
pushed a commit
to IntersectMBO/ouroboros-consensus
that referenced
this pull request
Oct 21, 2024
# Description Use `typed-protocols-0.3.0.0`. Depends on: * [x] input-output-hk/typed-protocols#52 * [x] input-output-hk/typed-protocols#61 * [x] IntersectMBO/ouroboros-network#4935 - **Updated to use typed-protocols-0.3.0.0** - **Added KeepAlive tracer**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59