Skip to content

Fixed the bug with wrong webviewOffset (issue reported for iPhone X and other iOS devices) #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+29 −3
Open

Fixed the bug with wrong webviewOffset (issue reported for iPhone X and other iOS devices) #170

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4eb6154
Fixed the bug with wrong webviewOffset. The offset should be calculat…
michal-th Dec 17, 2017
d3f3059
Allowing custom url scheme opening
Nov 20, 2018
ade64dc
Allowing custom url scheme opening
Nov 20, 2018
7acb525
Allowing custom url scheme opening
Nov 20, 2018
2f63d65
Allowing custom url scheme opening
Nov 20, 2018
cb528de
Allowing custom url scheme opening
Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ios/CDVThemeableBrowser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,11 +1336,13 @@ - (float) getStatusBarOffset {

- (void) rePositionViews {
CGFloat toolbarHeight = [self getFloatFromDict:_browserOptions.toolbar withKey:kThemeableBrowserPropHeight withDefault:TOOLBAR_DEF_HEIGHT];
CGFloat webviewOffset = _browserOptions.fullscreen ? 0.0 : toolbarHeight;
CGFloat statusBarOffset = [self getStatusBarOffset];
CGFloat webviewOffset = _browserOptions.fullscreen ? 0.0 : toolbarHeight + statusBarOffset;


if ([_browserOptions.toolbarposition isEqualToString:kThemeableBrowserToolbarBarPositionTop]) {
[self.webView setFrame:CGRectMake(self.webView.frame.origin.x, webviewOffset, self.webView.frame.size.width, self.webView.frame.size.height)];
[self.toolbar setFrame:CGRectMake(self.toolbar.frame.origin.x, [self getStatusBarOffset], self.toolbar.frame.size.width, self.toolbar.frame.size.height)];
[self.toolbar setFrame:CGRectMake(self.toolbar.frame.origin.x, statusBarOffset, self.toolbar.frame.size.width, self.toolbar.frame.size.height)];
}

CGFloat screenWidth = CGRectGetWidth(self.view.frame);
Expand Down