Potentially support ALB

[alexparlett]

@tobyclemson we're finding the need to upgrade to ALB's and wondered how that would fit into this module.

It's tightly coupled with its inputs / outputs to the classic aws_elb.

We could potentially have a type variable and use that along with count / ternary to allow the two different terraform resources, however that seems fairly hacky to have to have var.type == checks everywhere.

Or we could just straight upgrade to the new type load balancers and not support classic anymore? An alb would provide the same functionality as this module already provides I believe.

Wondered if you had any thoughts?

[tobyclemson]

Hey @alexparlett,

This was one of the first load balancer modules I created but these days I think I've been using https://github.com/infrablocks/terraform-aws-classic-load-balancer and https://github.com/infrablocks/terraform-aws-network-load-balancer instead.

I would be very happy if you put together a terraform-aws-application-load-balancer module as it has been on my list for a long time. I would use terraform-aws-network-load-balancer as a base as there are lots of interface similarities.

My longer term goal was to do as you say and make the terraform-aws-ecs-load-balancer delegate to one of the above 2 modules based on parameters, whilst baking in a few conventions around using the load balancers in ECS so switching on var.type == as you say would make sense in that case.

Let me know how you'd like to proceed and I can create a repo / add you as a maintainer.
Thanks,
Toby

[alexparlett]

Hi @tobyclemson

Thanks for that, it's really helpful.

Happy to align to your goals and create terraform-aws-application-load-balancermodule.

Thanks,
Alex

[tobyclemson]

Ok great, I'll create a repo and add you as a maintainer.

Can I discuss AWS credentials with you offline? On WhatsApp maybe?

Thanks,
Toby

[alexparlett]

Sure sounds good, I'll get your details off someone here who has them if thats ok?

Thanks,
Alex

[tobyclemson]

Yep, @CorinChappy has my number.