feat: give access to underlying data as object and as form data object #2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
Okay, I will add the tests in the coming hours. |
pascalbaljet
added
the
needs more info/work
|
@MeiKatz Any updates on this? |
|
I am still trying to write the tests for this. Until now I wasn't successful with this |
No problem! Shall I write them? |
|
This would be great. I guess I can learn from you how to do this in the future if there is another time I like to contribute. |
MeiKatz
commented
Oct 28, 2025
| await page.fill('#name', 'John Doe') | ||
| await page.getByRole('button', { name: 'Test getData()' }).click() | ||
|
|
||
| const result = consoleMessages.messages.find((msg) => msg.includes('getData result:')) |
There was a problem hiding this comment.
Okay, consoleMessages was the missing piece. I didn't know about this and that I could listen to console.log() this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Form />is a great addition to InertiaJS. But it would be greater if I could use it for sending manual requests to my api and benefit from the other features offered by<Form />. Currently there is no good way for accessing either the form element itself or the data managed by the Form component. I don't want to useuseForm()and have to manually handle the state of my input fields. Getting access to the form data as FormData object or as an plain old JS object would be great.I currently omitted the tests. If the feature is accepted I will add them.