Skip to content

Typing, scikit-build core #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jun 3, 2025
Merged

Typing, scikit-build core #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
f40fb59
Fix install docs
inducer Dec 19, 2024
ffe3842
gen_wrap: generate function signatures
inducer Dec 19, 2024
2ed9591
Add py.typed marker
inducer Dec 19, 2024
be1fd9a
Sphinx: remove signature processing
inducer Dec 19, 2024
6dbb52d
Remove deprecated SuppressedWarnings
inducer Dec 19, 2024
1125278
__init__: import from _isl, don't assign
inducer Dec 19, 2024
8639388
Annotate pwaff_get_pieces
inducer Dec 19, 2024
0ad3681
doc: Delete a now-extraneous comment on Python 2's long integers
inducer May 28, 2025
13de9b9
Fix an import shadow in __init__
inducer Dec 19, 2024
da6da60
Configure ruff ignores for stub file
inducer Dec 19, 2024
9bf7d0a
Bump min Python version to 3.10
inducer May 22, 2025
ec674e0
setup.py: Add commented-out bit showing how to enable a debug build
inducer May 22, 2025
f925ccf
Add bare-bones basedpyright config
inducer May 22, 2025
1a423e4
Enable TC ruff checks
inducer May 22, 2025
38c8dbb
Add some type annotations to gen_wrap
inducer May 22, 2025
4325774
Fix (apparently-3.12+) escapes-within-f-strings
inducer May 22, 2025
c22be6d
Split monkeypatching out of islpy/__init__.py into separate file, add…
inducer May 22, 2025
d012fbb
Add a stub generator
inducer May 22, 2025
bc37c53
Limit Github actions PR concurrency
inducer May 22, 2025
f6d4ed6
CMakeLists: move to 4-wide indentation
inducer May 22, 2025
dead611
Fix doc build for typed islpy
inducer May 28, 2025
d5807ca
Switch to scikit build core
inducer May 29, 2025
3e039e2
gen_wrap: Remove logic to store preprocessed headers
inducer May 26, 2025
5072a6d
gen_wrap: improve some types
inducer May 28, 2025
e7387d9
gen_wrap: Fix type annotation for tuple types
inducer May 26, 2025
64f4e84
gen_wrap: annotate callback types
inducer May 26, 2025
1ef5fd5
gen_wrap: Refactor wrapper/exposer invocation
inducer May 28, 2025
70a5c83
gen_wrap: Refactor generation of self-upcasts
inducer May 28, 2025
29d0d6f
gen_wrap: let stubs allow for automatic upcasts
inducer May 29, 2025
427ecf5
gen_wrap: Reject unexpected self classes
inducer May 31, 2025
c63a7e5
gen_wrap: get_dim_name can return None
inducer May 31, 2025
a1b58b8
Add some types in islpy.__init__
inducer Jun 2, 2025
5ca23cb
Add a basedpyright CI
inducer Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
214 changes: 214 additions & 0 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,214 @@
{
"files": {
"./islpy/_isl.pyi": [
{
"code": "reportAssignmentType",
"range": {
"startColumn": 13,
"endColumn": 15,
"lineCount": 1
}
},
{
"code": "reportAssignmentType",
"range": {
"startColumn": 13,
"endColumn": 15,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportIncompatibleMethodOverride",
"range": {
"startColumn": 8,
"endColumn": 14,
"lineCount": 1
}
},
{
"code": "reportIncompatibleMethodOverride",
"range": {
"startColumn": 8,
"endColumn": 14,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 19,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 38,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 37,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 37,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 36,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 23,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 22,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 38,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 37,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 37,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 36,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 23,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 22,
"lineCount": 1
}
},
{
"code": "reportOverlappingOverload",
"range": {
"startColumn": 8,
"endColumn": 12,
"lineCount": 1
}
}
]
}
}
24 changes: 22 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
schedule:
- cron: '17 3 * * 0'

concurrency:
group: ${{ github.head_ref || github.ref_name }}
cancel-in-progress: true

jobs:
ruff:
name: Ruff
Expand All @@ -24,7 +28,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.10', '3.x']
python-version: ['3.10', '3.12', '3.x']
steps:
- uses: actions/checkout@v4
-
Expand All @@ -37,12 +41,28 @@ jobs:
curl -L -O https://gitlab.tiker.net/inducer/ci-support/raw/main/build-and-test-py-project.sh
. ./build-and-test-py-project.sh

basdedpyright:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.x'
- name: "Main Script"
run: |
curl -L -O https://tiker.net/ci-support-v0
. ./ci-support-v0
build_py_project_in_venv
pip install nanobind typing-extensions basedpyright
(cd stubgen; python stubgen.py)
basedpyright islpy/_isl.pyi

examples:
name: Examples Linux on Py${{ matrix.python-version }}
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ['3.8', '3.10', '3.x']
python-version: ['3.10', '3.12', '3.x']
steps:
- uses: actions/checkout@v4
-
Expand Down
Loading
Loading