Skip to content

Conversation

@wataru86
Copy link
Member

@wataru86 wataru86 commented May 2, 2023

gjtorikian and others added 26 commits November 10, 2022 19:25
cmark-gfm removed the redundant extensions header in
github/cmark-gfm#289
…gfm.10

Release 0.23.9 --> update to 0.29.0.gfm.11
@wataru86 wataru86 self-assigned this May 8, 2023
@wataru86 wataru86 marked this pull request as ready for review May 8, 2023 03:17
@wataru86 wataru86 requested a review from mziyut May 8, 2023 03:18
Copy link

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've commented a few pointers. Please check them out.


module QiitaMarker
VERSION = "0.23.6.2"
VERSION = "0.23.9"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think VERSION should be changed.

Suggested change
VERSION = "0.23.9"
VERSION = "0.23.6.2"

@wataru86
Copy link
Member Author

wataru86 commented May 9, 2023

https://github.com/increments/qiita_marker/actions/runs/4924602077/jobs/8797820777?pr=40

/opt/hostedtoolcache/Ruby/3.2.2/x64/bin/ruby --version
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [x86_64-linux]
Took 0.03 seconds

ruby-version is 3.0 , but 3.2 installed.

ruby-version: 3.0

This is a known problem and writing '3.0' will solve it: ruby/setup-ruby#115

@wataru86 wataru86 requested a review from mziyut May 15, 2023 09:42
Copy link

@mziyut mziyut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@wataru86 wataru86 force-pushed the merge-upstream-v0.23.9 branch from 7d9aaef to 63a84b2 Compare May 16, 2023 01:45
@wataru86 wataru86 merged commit 6d675e2 into main May 16, 2023
@wataru86 wataru86 deleted the merge-upstream-v0.23.9 branch May 16, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants