Unable to resolve path to module with aliases.

[sebastien-comeau]

Starting from tinyglobby@^0.2.11, eslint-import-resolver-typescript is unable to resolve module paths when using aliases. As a workaround, I had to override tinyglobby to version 0.2.10 to restore functionality.

This issue can be reproduced in my pull request DTS-STN/future-sir#226 with commit DTS-STN/future-sir@e1da254, where the problem occurs. The next commit DTS-STN/future-sir@f0e3ce2 includes the override, which resolves the issue.

[carlocorradini]

That's because tinyglobby is configured to avoid dot directories.
@JounQin @SukkaW Do you want to allow dot directories?
I don't know the implications in security/performance

[carlocorradini]

Here

eslint-import-resolver-typescript/src/index.ts

Line 461 in 4f47f8a

? globSync(tsconfigResult.config.include, {

and here

eslint-import-resolver-typescript/src/index.ts

Line 440 in 4f47f8a

globSync(defaultInclude, {

we can add dot: true

[JounQin]

Does this means tinyglobby breaks in a patch version?

[carlocorradini]

I don't know but I've seen the dot option also in version 0.2.10 if I'm not allucinated.
If it's there previously, it was silently ignored.
Tomorrow I'll push a PR with a test for both tsconfig and include property

[SuperchupuDev]

hi! tinyglobby author here. that's very odd. tinyglobby (in both 0.2.10 and 0.2.11) is configured by default to avoid dot directories, behavior shouldn't have changed between versions. so either 0.2.10 mistakenly didn't skip directories which should have been skipped or 0.2.11 somehow made dot matching (with the dot option disabled) stricter. if any of you can provide a reproducible example of results changing between the two versions i can take a closer look

[carlocorradini]

@SuperchupuDev

1. Clone https://github.com/carlocorradini/eslint-import-resolver-typescript
2. cd eslint-import-resolver-typescript
3. git checkout dot
4. yarn --immutable
5. yarn remove tinyglobby
6. yarn add tinyglobby@0.2.10
7. Open src/index.ts and remove dot: true option from every call to globSync function
8. yarn run-s build test

There are three new tests that look for dot directories.
Let's verify if they fail or pass, even though the dot: true option was deleted.

[chrisweb]

As a workaround I downgraded to eslint-import-resolver-typescript 3.7.0

Does this means tinyglobby breaks in a patch version?

The latest version that supports aliases (for me) is eslint-import-resolver-typescript 3.7.0 (which was still using fast-glob), downgrading eslint-import-resolver-typescript from 3.8.2 to 3.8.0 was not enough

tinyglobby (in both 0.2.10 and 0.2.11) is configured by default to avoid dot directories

I downgraded my tinyglobby from 0.2.11 to v0.2.10 and it made no difference (both break aliases when not using the dot option)

[carlocorradini]

@chrisweb See PR #360

It should be merged today and a new version will be released automatically

[SuperchupuDev]

great will check it out. meanwhile if you can manage to provide a minimal isolated example that only involves one glob call it'd be greatly appreciated 🙏

[SuperchupuDev]

@carlocorradini while the tests do fail with 0.2.11, i added a few asserts and installing 0.2.10 at the same time to make sure the result didn't change between versions, but i can't seem to find any assert failure