Skip to content

feat: library disableVIdeoTranscode (db + server + frontend) #20797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thegabriele97
Copy link

Description

Feature Request #8845.

It is my first PR to Immich so I hope I am doing things well.

  • Still missing translation keys instead of pure text in the frontend.
  • Missing tests

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

image image image

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label.

@thegabriele97 thegabriele97 changed the title [feat] library disableVIdeoTranscode (db + server + frontend) feat: library disableVIdeoTranscode (db + server + frontend) Aug 8, 2025
@alextran1502
Copy link
Member

Thank you for the PR, but I am pretty positive that we don't want to handle this granularity behavior for the transcoding process.

@thegabriele97
Copy link
Author

Thank you for the PR, but I am pretty positive that we don't want to handle this granularity behavior for the transcoding process.

Oh I understand, let me know if you prefer I continue this PR or I close it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants