Skip to content

feat: share memories via shared albums #20754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ExceptionsOccur
Copy link
Contributor

Description

  1. Modified the getByDayOfYear method in asset.repository.ts of the server to expand the query scope to shared albums.
  2. Added a judgment in the web page memory-view.svelte to hide the navigation buttons of assets in memories that do not belong to the current user.
  3. Similar to the web page, added a judgment in memory_button_info.dart of the mobile version to hide the navigation buttons of assets in memories that do not belong to the current user. Both the old and new versions of the components have been modified.

How Has This Been Tested?

There are multiple users and shared albums on my Immich server. The modified version has been running stably on my NAS for over 3 days, and based on v1.135.3, it has been operating reliably for more than a month. The modifications to the web and mobile versions are also functioning well.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

Copy link
Contributor

github-actions bot commented Aug 7, 2025

Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant