Skip to content

Conversation

Kixiron
Copy link

@Kixiron Kixiron commented May 18, 2022

  • Ran rustfmt across the codebase
  • Added rustfmt checks to the github ci

@Kixiron
Copy link
Author

Kixiron commented May 18, 2022

r? @HeroicKatora

@kornelski
Copy link
Contributor

I think rustfmt checks in CI are counter-productive. It slows down CI feedback, and rejects PRs for trivial reasons.

But the worst effect of rustfmt is blowing up small code changes into big reformatting of entire blocks. It makes reviewing of PRs more difficult. Addition or deletion of a single line or word has a nice readable diff, but if it happens to push the code over some threshold in rustfmt, it can cause entire block to be rewrapped, and then it's harder to see what has actually changed.

@kornelski kornelski closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants