Skip to content

Redesign AccessControlSettingOperation using ContextExclusionFilterFactory #290

@ldko

Description

@ldko

Currently AccessControlSettingOperation seems awkward as it implements BooleanOperator with its isTrue() method directly setting the exclusionFilter on the WaybackRequest instance before always returning true. To be consistent with development moving toward creating ExclusionFilters by implementing ContextExclusionFilterFactory, AccessControlSettingOperation should be redesigned for OpenWayback 3.0. This issue stems from the discussion on issue #259 where Kenji recommended:

"Toward 3.0, I'd propose redesigning AccessControlSettingOperation as ContextExclusionFilterFactory and have it set up through AccessPoint.exclusionFactory. It'll require adding WaybackRequest (or narrower interface) to its getExclusionFilter method."

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions