Refactor WeatherSource and WeatherSourceWrapper. #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala # src/main/scala/edu/ie3/simona/service/weather/WeatherSource.scala # src/main/scala/edu/ie3/simona/service/weather/WeatherSourceWrapper.scala # src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala # src/test/scala/edu/ie3/simona/service/weather/WeatherSourceSpec.scala
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
…-Wrapper # Conflicts: # src/main/scala/edu/ie3/simona/config/ConfigFailFast.scala
…-Wrapper # Conflicts: # CHANGELOG.md # src/main/scala/edu/ie3/simona/service/weather/SampleWeatherSource.scala # src/test/scala/edu/ie3/simona/service/weather/WeatherSourceSpec.scala
…-Wrapper # Conflicts: # src/test/scala/edu/ie3/simona/config/ConfigFailFastSpec.scala
danielfeismann
approved these changes
Jul 11, 2024
|
@danielfeismann I was still reviewing. Will just submit the points I found now after the fact |
Comment on lines
+656
to
+657
| s"No coordinate source defined! This is currently not supported! Please provide the config parameters for one " + | ||
| s"of the following coordinate sources:\n\t${supportedCoordinateSources.mkString("\n\t")}" |
There was a problem hiding this comment.
It should still be possible to run simulations with no weather data at all. Did you check if that works? We only need to fail here if there's a weather source but no coordinate source
There was a problem hiding this comment.
Actually, there has been no option to not use weather data before. So this would be a larger issue.
There was a problem hiding this comment.
@sebastian-peter Will you create a new issue for this?
Comment on lines
+600
to
+604
| case None | Some(_) => | ||
| throw new InvalidConfigParameterException( | ||
| s"No weather source defined! This is currently not supported! Please provide the config parameters for one " + | ||
| s"of the following weather sources:\n\t${supportedWeatherSources.mkString("\n\t")}" | ||
| ) |
|
Sorry @sebastian-peter wasn't aware that you also had a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #180
May help with or resolves #625