Skip to content

Colored maps for node trace plotting #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Sep 22, 2025
Merged

Colored maps for node trace plotting #350

merged 48 commits into from
Sep 22, 2025

Conversation

@danielfeismann
Copy link
Member

@danielfeismann danielfeismann commented Jul 31, 2025 •
edited
Loading

@danielfeismann danielfeismann added the enhancement New feature or request label Jul 31, 2025
@danielfeismann danielfeismann self-assigned this Jul 31, 2025
@danielfeismann danielfeismann marked this pull request as ready for review July 31, 2025 16:15
@danielfeismann danielfeismann mentioned this pull request Aug 6, 2025
Open
@danielfeismann
Merge branch 'main' into df/#349-colored-node-trace
0862f71 
# Conflicts:
#	pypsdm/plots/grid.py
@danielfeismann
Merge branch 'main' into df/#349-colored-node-trace
f577919 
# Conflicts:
#	poetry.lock
@danielfeismann
poetry
c53b045
@danielfeismann
Merge branch 'main' into df/#349-colored-node-trace
d039836 
# Conflicts:
#	CHANGELOG.md
@danielfeismann
Merge branch 'main' into df/#349-colored-node-trace
187d4c4 
# Conflicts:
#	CHANGELOG.md
#	docs/nbs/input_models.ipynb
#	docs/nbs/plotting_utilities.ipynb
#	docs/nbs/result_models.ipynb
#	poetry.lock
@danielfeismann
Merge branch 'df/#365-nb-clean' into df/#349-colored-node-trace
694f8b1 
# Conflicts:
#	CHANGELOG.md
@danielfeismann
test with nb-clean
1295bdf
@danielfeismann
test with result_models
587f4b8
@danielfeismann
preserve-cell-outputs
d781a5b
@danielfeismann danielfeismann marked this pull request as draft August 12, 2025 17:03
@danielfeismann
Merge branch 'main' into df/#349-colored-node-trace
4ce220c 
# Conflicts:
#	docs/nbs/input_models.ipynb
#	docs/nbs/plotting_utilities.ipynb
#	docs/nbs/result_models.ipynb
#	poetry.lock
#	pyproject.toml
@danielfeismann
Merge branch 'main' into df/#349-colored-node-trace
76779d5 
# Conflicts:
#	.pre-commit-config.yaml
#	CHANGELOG.md
#	docs/nbs/input_models.ipynb
#	docs/nbs/result_models.ipynb
#	poetry.lock
#	pyproject.toml
#	tests/docs/nbs/test_notebooks.py
@danielfeismann danielfeismann marked this pull request as ready for review August 21, 2025 13:27
staudtMarius
staudtMarius requested changes Sep 19, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question from my side.

staudtMarius
staudtMarius requested changes Sep 22, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question from my side.

staudtMarius
staudtMarius approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for including my remarks.

@staudtMarius staudtMarius merged commit 8b53dcd into main Sep 22, 2025
6 checks passed
@staudtMarius staudtMarius deleted the df/#349-colored-node-trace branch September 22, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staudtMarius staudtMarius staudtMarius approved these changes

Assignees

@danielfeismann danielfeismann

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Colored maps for node trace plotting

2 participants

@danielfeismann @staudtMarius