Skip to content

Fixing CsvSystemParticipantSourceTest #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Fixing CsvSystemParticipantSourceTest #984

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cefbcca
Fixing `CsvSystemParticipantSourceTest`
staudtMarius Jan 8, 2024
370ef59
Adding info to `CHANGELOG`.
staudtMarius Jan 8, 2024
9c05a03
Merge branch 'dev' into ms/#958-Fix-CsvSystemParticipantSourceTest
staudtMarius Jan 18, 2024
1f72b44
Adapting `CsvSystemParticipantSourceTest`.
staudtMarius Jan 18, 2024
49e9686
fmt
staudtMarius Jan 18, 2024
f7991d8
Merge branch 'dev' into ms/#958-Fix-CsvSystemParticipantSourceTest
sebastian-peter Jan 22, 2024
18f7ad5
Implementing requested changes.
staudtMarius Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed Couchbase integration tests that randomly failed [#755](https://github.com/ie3-institute/PowerSystemDataModel/issues/755)
- Fixed hyperlink in line documentation [#965](https://github.com/ie3-institute/PowerSystemDataModel/issues/965)
- Fixed some tests no failing when they should [#958](https://github.com/ie3-institute/PowerSystemDataModel/issues/958)

### Changed
- Changing from comparing strings to comparing uuids in `EntitySource.findFirstEntityByUuid` [#829](https://github.com/ie3-institute/PowerSystemDataModel/issues/829)
Expand Down
9 changes: 3 additions & 6 deletions src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvRawGridSourceTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,7 @@ class CsvRawGridSourceTest extends Specification implements CsvTestDataMeta {

then: "everything is fine"
actualSet.size() == expectedSet.size()
actualSet.every {
it.success
}
Try.scanCollection(actualSet, List).success

actualSet.stream().map {
it.data.get()
Expand Down Expand Up @@ -260,9 +258,8 @@ class CsvRawGridSourceTest extends Specification implements CsvTestDataMeta {

then: "everything is fine"
actualSet.size() == expectedSet.size()
actualSet.every {
it.success
}
Try.scanCollection(actualSet, List).success

actualSet.stream().map {
it.data.get()
}.toList().containsAll(expectedSet)
Expand Down
Loading