Skip to content

Change from cleanup to cleanupSpec for BufferedCsvWriterTest #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Change from cleanup to cleanupSpec for BufferedCsvWriterTest #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6778013
change from cleanup to cleanupSpec for BufferedCsvWriterTest
danielfeismann Oct 13, 2023
efc7b6a
Merge branch 'dev' into df/#809_cleanup
danielfeismann Oct 13, 2023
517a912
Merge branch 'dev' into df/#809_cleanup
danielfeismann Oct 18, 2023
3f34b33
Merge branch 'dev' into df/#809_cleanup
sebastian-peter Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Use nio paths instead of strings for file path [#723](https://github.com/ie3-institute/PowerSystemDataModel/issues/723)
- Data source will throw an exceptions instead of returning an empty optionals [#707](https://github.com/ie3-institute/PowerSystemDataModel/issues/707)
- Improving `ValidationUtils` [#758](https://github.com/ie3-institute/PowerSystemDataModel/issues/758)
- CleanUp `BufferedCsvWriterTest` only after all tests are completed [#809](https://github.com/ie3-institute/PowerSystemDataModel/issues/809)


## [3.0.0] - 2023-02-16
Expand Down
3 changes: 1 addition & 2 deletions src/test/groovy/edu/ie3/datamodel/io/csv/BufferedCsvWriterTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ package edu.ie3.datamodel.io.csv
import edu.ie3.datamodel.exceptions.FileException
import edu.ie3.datamodel.exceptions.SinkException
import edu.ie3.util.io.FileIOUtils
import org.apache.commons.io.FilenameUtils
import spock.lang.Shared
import spock.lang.Specification

Expand All @@ -23,7 +22,7 @@ class BufferedCsvWriterTest extends Specification {
tmpDirectory = Files.createTempDirectory("psdm_csv_buffered_writer_")
}

def cleanup() {
def cleanupSpec() {
FileIOUtils.deleteRecursively(tmpDirectory)
}

Expand Down